-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[py] fix doc for find_elements #15411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit f17dd08dd32998a310510f0abc44e5b484202a4d.
This reverts commit cc16e3f. oops
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Lets also improve the Returns sections:
Returns:
-------
WebElement
list of `WebElements` matching locator strategy found on the page.
"""
should instead be:
Returns:
-------
List
list of `WebElements` matching locator strategy found on the page
"""
Thanks @shbenzer for the suggestion. I have done the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Delta456
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Motivation and Context
Fixes docstring for
find_elements
Types of changes
Checklist
PR Type
Bug fix, Documentation
Description
Corrected example code in
find_elements
docstrings across multiple files.Ensured consistency in documentation for
find_elements
method.Improved clarity and accuracy of usage examples for developers.
Changes walkthrough 📝
shadowroot.py
Corrected `find_elements` example in docstring
py/selenium/webdriver/remote/shadowroot.py
find_elements
docstring to usefind_elements
instead of
find_element
.webdriver.py
Updated `find_elements` example in docstring
py/selenium/webdriver/remote/webdriver.py
find_elements
docstring to correctly usefind_elements
.webelement.py
Fixed `find_elements` example in docstring
py/selenium/webdriver/remote/webelement.py
find_elements
docstring to usefind_elements
correctly.