Skip to content

[java] Allow null input in FluentWait #13558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

valfirst
Copy link
Contributor

@valfirst valfirst commented Feb 7, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

input in FluentWait should be handled by users in Function<? super T, V> isTrue.

Motivation and Context

There is no reason to require input if Function implementation doesn't require such input. More generic solution is to overload the methods to allow to pass Supplier alongside with Function, but it will require changes in API.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@pujagani pujagani added the C-java Java Bindings label Feb 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7b41033) 58.48% compared to head (2bd1602) 58.48%.
Report is 4 commits behind head on trunk.

❗ Current head 2bd1602 differs from pull request most recent head af69b34. Consider uploading reports for the commit af69b34 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13558   +/-   ##
=======================================
  Coverage   58.48%   58.48%           
=======================================
  Files          86       86           
  Lines        5270     5270           
  Branches      220      220           
=======================================
  Hits         3082     3082           
  Misses       1968     1968           
  Partials      220      220           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diemol diemol force-pushed the allow-null-input-in-fluent-wait branch from af69b34 to 7440a7c Compare February 8, 2024 10:02
@diemol diemol merged commit 85dd3b4 into SeleniumHQ:trunk Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-java Java Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants