Skip to content

[rust] Add timestamps to Selenium Manager logs #13554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

bonigarcia
Copy link
Member

Description

This PR allows to log the timestamp in the regular (LOGGER) output type, as follows:

./selenium-manager --browser chrome --debug
[2024-02-07T10:20:05.129Z DEBUG] chromedriver not found in PATH
[2024-02-07T10:20:05.130Z DEBUG] chrome detected at C:\Program Files\Google\Chrome\Application\chrome.exe
[2024-02-07T10:20:05.132Z DEBUG] Running command: wmic datafile where name='C:\\Program Files\\Google\\Chrome\\Application\\chrome.exe' get Version /value
[2024-02-07T10:20:05.214Z DEBUG] Output: "\r\r\n\r\r\nVersion=121.0.6167.140\r\r\n\r\r\n\r\r\n\r"
[2024-02-07T10:20:05.220Z DEBUG] Detected browser: chrome 121.0.6167.140
[2024-02-07T10:20:05.223Z DEBUG] Required driver: chromedriver 121.0.6167.85
[2024-02-07T10:20:05.223Z DEBUG] chromedriver 121.0.6167.85 already in the cache
[2024-02-07T10:20:05.224Z INFO ] Driver path: C:\Users\boni\.cache\selenium\chromedriver\win64\121.0.6167.85\chromedriver.exe
[2024-02-07T10:20:05.224Z INFO ] Browser path: C:\Program Files\Google\Chrome\Application\chrome.exe

Motivation and Context

Requested in #13421.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonigarcia bonigarcia added the C-rust Rust code is mostly Selenium Manager label Feb 7, 2024
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bonigarcia!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-rust Rust code is mostly Selenium Manager
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants