Skip to content

[js] Organize BiDi test based on the module #13408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 9, 2024

Conversation

pujagani
Copy link
Contributor

@pujagani pujagani commented Jan 8, 2024

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

BiDi tests were in one file and the list would grow with more exhaustive tests. Splitting the file to organize the tests module wise. No logical changes, only imports are cleaned up.

Motivation and Context

Easy to run tests and navigate them specially during TDD.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0f42c3) 58.07% compared to head (b4dbf09) 58.07%.
Report is 2 commits behind head on trunk.

❗ Current head b4dbf09 differs from pull request most recent head 6ca088f. Consider uploading reports for the commit 6ca088f to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13408   +/-   ##
=======================================
  Coverage   58.07%   58.07%           
=======================================
  Files          88       88           
  Lines        5340     5340           
  Branches      224      224           
=======================================
  Hits         3101     3101           
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pujagani pujagani marked this pull request as ready for review January 9, 2024 04:45
@pujagani pujagani added the C-nodejs JavaScript Bindings label Jan 9, 2024
@pujagani pujagani merged commit 3bfd6c4 into SeleniumHQ:trunk Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-nodejs JavaScript Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants