Skip to content

[build] Remove features that are not w3c compliant #13372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 1, 2024
Merged

Conversation

titusfortner
Copy link
Member

Description

  • Remove non-compliant commands that are not being used in Selenium code anywhere
    • GET_ALL_SESSIONS
    • ELEMENT_EQUALS
    • SET_ALERT_CREDENTIALS
    • GET_APP_CACHE_STATUS
    • IS_BROWSER_ONLINE
    • SET_BROWSER_ONLINE
    • GET_SESSION_LOGS
  • Remove commands that are implemented by the single subclass (W3CHttpCommandCodec)
    • GET_AVAILABLE_LOG_TYPES
    • GET_ELEMENT_LOCATION
    • GET_ELEMENT_SIZE
    • GET_LOG
  • Deprecate features that shouldn't work because the endpoints are no longer valid
    • Getting & Setting location (geo-location)
    • Getting & Setting network connection

Motivation and Context

  • Slowly removing things that don't work or at least are not compliant

Future Considerations

  • Need to contact Appium about things they need to implement so we can get rid of them (alternately we can change the namespacing on them to be w3c compliant; kind of depends on what we want to live where in the two code bases)
    • GET_SCREEN_ORIENTATION
    • SET_SCREEN_ORIENTATION
    • GET_SCREEN_ROTATION
    • SET_SCREEN_ROTATION
    • SWITCH_TO_CONTEXT
    • GET_CURRENT_CONTEXT_HANDLE
    • GET_CONTEXT_HANDLES
  • Can we merge these classes since we no longer have multiple implementations? I don't think this would affect how we are moving to BiDi spec.

@titusfortner titusfortner added the C-java Java Bindings label Dec 29, 2023
@titusfortner titusfortner added this to the 4.17 milestone Dec 29, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f9b606) 58.05% compared to head (2103dba) 58.05%.
Report is 1 commits behind head on trunk.

❗ Current head 2103dba differs from pull request most recent head 5aca69d. Consider uploading reports for the commit 5aca69d to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13372   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          88       88           
  Lines        5338     5338           
  Branches      224      224           
=======================================
  Hits         3099     3099           
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, if the build passes, you should merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-java Java Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants