Skip to content

[build] update script for change logs #13356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2023
Merged

[build] update script for change logs #13356

merged 1 commit into from
Dec 31, 2023

Conversation

titusfortner
Copy link
Member

Making this a PR just to get feedback...

This script limits what is getting added to changelogs to the src or lib directories, so changes to root or test directories won't get added to changelogs. Is this what we want. I typically don't add to changelogs anything that doesn't affect users, but maybe that's not what we want? Let me know.

Also, because this took a lot of work... this works for both minor & patch releases, and is automatically called from the versions task.

For instance, this bumps patch version and adds java commits to the readme since previous patch version

./go java:version["4.16.2"]

@titusfortner titusfortner added A-needs decision TLC needs to discuss and agree B-build Includes scripting, bazel and CI integrations labels Dec 23, 2023
@titusfortner titusfortner added this to the 4.17 milestone Dec 26, 2023
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this commit the changes or leaves changes to be reviewed before committing and pushing?

@titusfortner
Copy link
Member Author

The automated build process I've been working on always prompts before commits, it doesn't prompt for tagging because we can fix that if it's wrong.

I ended up already merging most of what was originally in this PR just so I could work with the whole build process more easily.

This PR is now just asking how much to limit what goes in the changelog

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it looks good to me.

@titusfortner titusfortner merged commit 3570209 into trunk Dec 31, 2023
@titusfortner titusfortner deleted the changelog branch December 31, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-needs decision TLC needs to discuss and agree B-build Includes scripting, bazel and CI integrations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants