Skip to content

[dotnet] Specify the dll as nuget content explicitly #13332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 20, 2023

Conversation

nvborisenko
Copy link
Member

@nvborisenko nvborisenko commented Dec 18, 2023

Description

Let's see how we can avoid [🐛 Bug]: Unpredictable nuget package structure while releasing a package in future.

Motivation and Context

This is a try to fix #13272

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nvborisenko nvborisenko requested a review from shs96c December 18, 2023 21:06
@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e745a91) 58.04% compared to head (4b4ac2e) 58.05%.
Report is 8 commits behind head on trunk.

❗ Current head 4b4ac2e differs from pull request most recent head c0a59da. Consider uploading reports for the commit c0a59da to get more accurate results

Files Patch % Lines
py/selenium/webdriver/firefox/firefox_binary.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #13332   +/-   ##
=======================================
  Coverage   58.04%   58.05%           
=======================================
  Files          88       88           
  Lines        5337     5338    +1     
  Branches      224      224           
=======================================
+ Hits         3098     3099    +1     
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nvborisenko
Copy link
Member Author

Great! Now we control what exactly should go to the nuget packages. If some file is missing, we get build error.

@titusfortner titusfortner merged commit e729e16 into SeleniumHQ:trunk Dec 20, 2023
@nvborisenko nvborisenko deleted the dotnet-nuget-precise branch February 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Unpredictable nuget package structure while releasing a package
3 participants