[build] Archive Selenium Manager Binaries

[titusfortner]

Status

This is in Draft because it is using my fork to demo the proof of concept.
This Git Hub Actions Run — https://github.com/titusfortner/selenium/actions/runs/7219076550
Made this commit — titusfortner/selenium_manager_debug@fab2d26
And did this release — https://github.com/titusfortner/selenium_manager_debug/releases/tag/selenium-manager-fab2d26

Description

• On every commit to trunk in the rust directory (too much? daily seemed too little and also too much?)
  • Builds all Selenium Manager binaries (including debug)
  • Creates a commit in a separate repo with the hash values of the files
  • Creates a tag from that commit and does a release, and uploads all selenium manager binaries
• Toggle Selenium Manager behavior in build based on pinned_browsers instead of stamp (the way I'm skipping downloading is definitely hacky, there is probably a better way)
• Deletes Selenium Manager binaries from repo
• selenium_manager.py file very similar to pinned_browsers.py to update the url and hash for the latest version of binaries

Motivation and Context

• Fixes [🚀 Feature]: Stop storing Selenium Manager binaries in Repo #13150
• Removes the need for [🚀 Feature]: Use Bazel for Selenium Manager #12620 & [🚀 Feature]: Release Selenium Manager with Bazel #13019
• If running tests with Selenium Manager it will use the exact binary that the user will have when released
• Less Windows Dev Pain
• Separate Repo makes it clear that these are archives not production releases
• Still it's an easy way for someone to grab a debug version of the binary and to try it locally to help troubleshoot problems

Future Considerations

• Remove all Bazel Rust things as Lost Cause
• Make build-selenium-manager.yml part of ci-rust.yml
• Would probably be better to store all the files in the releases zipped, but I got http_file working before I could figure out how to get http_archive working

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f1489d) 58.05% compared to head (f2256b6) 58.05%.
Report is 9 commits behind head on trunk.

❗ Current head f2256b6 differs from pull request most recent head 5ed6430. Consider uploading reports for the commit 5ed6430 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff           @@
##            trunk   #13314   +/-   ##
=======================================
  Coverage   58.05%   58.05%           
=======================================
  Files          88       88           
  Lines        5338     5338           
  Branches      224      224           
=======================================
  Hits         3099     3099           
  Misses       2015     2015           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[diemol]

This is pretty good, thank you @titusfortner!

I think building on every commit is fine, given that it does not change a lot.

[titusfortner]

Ok, I've updated the repo names to point to https://github.com/SeleniumHQ/selenium_manager_snapshots/ (the releases there were automatically generated by Selenium's CI).

I've moved the CI code from build-selenium-manager.yml to ci-rust.yml. Binaries are only built/released when rust directory has a commit and all tests are passing (or triggered manually).

[titusfortner]

I had this working, then I tweaked something and now it isn't deploying. At least it is passing RBE now. Once I figure out why it isn't releasing the binaries any more, I'll merge this.

[titusfortner]

Ok, this makes sense. It wasn't working as a PR because of tokens, but when I run this code as a Selenium branch, it works — https://github.com/SeleniumHQ/selenium/actions/runs/7331186361
So I'm merging it.