[java] bug(#12791) Grid vnc session is not using the --sub-path argument #13219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Fix: WebSocket connection for vnc session is not using the --sub-path argument #12791
Motivation and Context
When
--grid-url
is set with subPath e.g via docker envbut in node Capabilities, the URL still not have sub path
It is due to
rewrite
is missing to capture path from gridUrl if it has anyselenium/java/src/org/openqa/selenium/grid/node/local/LocalNode.java
Lines 838 to 842 in 6205337
This leads to the issue on grid UI, NoVNC live preview WebSocket connection incorrect, since the URL is constructed based on URL of
se:vnc
selenium/javascript/grid-ui/src/models/session-data.ts
Lines 53 to 60 in 6205337
Types of changes
Checklist