"Get Text" atom has to return the visible text from an element within a closed ShadowDOM #13211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a closed ShadowDOM. As discussed on issue SeleniumHQ#13132 the "Get Text" atom currently fails for elements that are located within a closed ShadowDOM. In those cases a check for ".shadowRoot" will not succeed because it's "null". This patch fixes the check by making sure that it is only run when a valid ShadowRoot is actually available. # Please enter the commit message for your changes. Lines starting
|
CC @43081j and @AutomatedTester for review. Thanks! |
AutomatedTester
approved these changes
Nov 28, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #13211 +/- ##
=======================================
Coverage 57.53% 57.53%
=======================================
Files 86 86
Lines 5310 5310
Branches 221 221
=======================================
Hits 3055 3055
Misses 2034 2034
Partials 221 221 ☔ View full report in Codecov by Sentry. |
43081j
approved these changes
Nov 28, 2023
|
@AutomatedTester the failing test for Firefox doesn't look like that it has been caused by my PR. Can you please check? Thanks! |
dev-velo
pushed a commit
to dev-velo/selenium
that referenced
this pull request
Nov 29, 2023
… a closed ShadowDOM (SeleniumHQ#13211) "Get Text" atom has to return the visible text from an element within a closed ShadowDOM. As discussed on issue SeleniumHQ#13132 the "Get Text" atom currently fails for elements that are located within a closed ShadowDOM. In those cases a check for ".shadowRoot" will not succeed because it's "null". This patch fixes the check by making sure that it is only run when a valid ShadowRoot is actually available. # Please enter the commit message for your changes. Lines starting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13132
Description
As discussed on issue #13132 the "Get Text" atom currently fails for elements that are located within a closed ShadowDOM. In those cases a check for
.shadowRootwill not succeed because it'snull. This patch fixes the check by making sure that it is only run when a valid ShadowRoot is actually available.Motivation and Context
This currently blocks WebDriver implementations using the
Get Textatom to correctly retrieve the visible text of such an element.Types of changes
Checklist