Skip to content

[py] filter which bidi logs are recorded based on event type #12951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Conversation

titusfortner
Copy link
Member

Description

Changed the logic for updating the console message based on whether the message is an error or a log type.

Motivation and Context

I updated the tests to show what doesn't work in current code.

@AutomatedTester I don't really understand how this is implemented, I'm just looking at the inputs/outputs. It appears that only one message can be processed, though, so a second execute script never gets triggered. I think that means it is ok to match off of messages.value.type_, but let me know if I'm misunderstanding this.

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (82f7cf7) 57.99% compared to head (26fe974) 58.03%.

❗ Current head 26fe974 differs from pull request most recent head 6fcefa0. Consider uploading reports for the commit 6fcefa0 to get more accurate results

Files Patch % Lines
py/selenium/webdriver/common/log.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##            trunk   #12951      +/-   ##
==========================================
+ Coverage   57.99%   58.03%   +0.03%     
==========================================
  Files          88       88              
  Lines        5338     5335       -3     
  Branches      224      224              
==========================================
  Hits         3096     3096              
+ Misses       2018     2015       -3     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@isaulv isaulv added the C-py Python Bindings label Nov 9, 2023
@titusfortner titusfortner modified the milestones: 4.16, 4.17 Dec 1, 2023
@titusfortner
Copy link
Member Author

I think the code needs to be able to record more than just the first event, or only one event at a time, but I don't know how to implement it, so I'm backing away slowly. This change is now minor, so I'm merging it.

@titusfortner titusfortner merged commit 5b1b449 into trunk Dec 12, 2023
@titusfortner titusfortner deleted the py_log branch December 12, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-py Python Bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants