Skip to content

SymbolizeTable: express nonemptiness of lists in types #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2025
Merged

SymbolizeTable: express nonemptiness of lists in types #5

merged 1 commit into from
Mar 1, 2025

Conversation

Bodigrim
Copy link
Contributor

@Bodigrim Bodigrim commented Mar 1, 2025

Up to you, I'm fine if it feels too much complexity for a little gain. I just could not resist the temptation to enforce the invariant in types :)

Qqwy
Qqwy approved these changes Mar 1, 2025
View reviewed changes
Copy link
Owner

@Qqwy Qqwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh! No, I really like it! I hadn't even considered that since we remove the full key-value pair when the last tombstone is removed, we're modeling a NonEmpty list here.

😍

@Qqwy Qqwy merged commit a2c2096 into Qqwy:main Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qqwy Qqwy Qqwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bodigrim @Qqwy