Refactors (ApplicativeDo, record syntax, fetchWith) #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maralorn
approved these changes
Mar 5, 2022
63201fd to
637eddc
Compare
|
(force-pushed to trigger CI with 8.8.4) |
I … accidentally looked at the code and had a bunch of time 😅 |
637eddc to
8fa2df7
Compare
This makes referencing fields a lot easier, and has been possible since GHC 8.0.1.
Improves readability quite considerably.
The reading flow is just a lot better if case matches are used.
We have a complete list of sources, thus we can use a simple enum to list all sources, this also leads to less ad-hoc string concatenation. The boolean logic should stay the same, but the double negation with `fetched` had me thinking for a bit.
From the DerivKind we can determine the command directly. This is still slightly not-nice, since the extra args depend on the prefetch command, but we might be able to remove that indirection as well.
Instead, add the few extra args that we want to pass to the `DerivKind` enum, which is * Whether to fetch git submodules * Whether to unpack an archive from a url/zip source
8fa2df7 to
17d4704
Compare
|
I had some weird rebasing issues, but now it should be rebased on master & the comments fixed |
|
Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few code refactors,
ApplicativeDowhere possiblefetchWithby moving most arguments into a single enum in multiple steps