Support Cabal 3.4.0.0 and GHC 9.0.x #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finalizePD uses PackageVersionConstraint instead of dependency since 3.4.0.0 (see also haskell/cabal#5570). This is a bit annoying since we need to do some CPP-stuff to support both 3.2.* and 3.4.0.0, but it is a good opportunity to clean up our use of Dependency: Since we always ignore the `LibraryName`s in `Dependency` and it is required to be a `NonEmptySet` since 3.4.0.0, we switch to using the simpler `PackageVersionConstraint` which doesn't care about `LibraryName` at all (just like us).
af7b4d3 to
f79f22c
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.