Skip to content

Make sure that nvComp is bundled also when WITH_DYNAMIC_CUDA_TOOLKIT is off #5909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2025

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 5, 2025

  • as WITH_DYNAMIC_CUDA_TOOLKIT makes precedence before WITH_DYNAMIC_*
    make sure that it is also turned on to skip bundling nvComp
    library

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • as WITH_DYNAMIC_CUDA_TOOLKIT makes precedence before WITH_DYNAMIC_*
    make sure that it is also turned on to skip bundling nvComp
    library

Additional information:

Affected modules and functionalities:

  • build helper

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
    • build process for certain configurations
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

…is off

- as WITH_DYNAMIC_CUDA_TOOLKIT makes precedence before WITH_DYNAMIC_*
  make sure that it is also turned on to skip bundling nvComp
  library

Signed-off-by: Janusz Lisiecki <[email protected]>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27938948]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [27938948]: BUILD PASSED

@JanuszL JanuszL merged commit 747b80b into NVIDIA:main May 6, 2025
6 checks passed
@JanuszL JanuszL deleted the fix_nvcomp_bundle branch May 6, 2025 14:05
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [29351341]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [29351341]: BUILD FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants