Skip to content

Errors returned by pipenv command not logged #1254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DonJayamanne opened this issue Mar 30, 2018 · 0 comments · Fixed by #1430
Closed

Errors returned by pipenv command not logged #1254

DonJayamanne opened this issue Mar 30, 2018 · 0 comments · Fixed by #1430
Assignees
@DonJayamanne
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
April 2018

Comments

@DonJayamanne
Copy link

When trying to invoke pipenv --venv we're not logging any errors returned.
What we found was that pipenv was installed, however the error returned was related to http://click.pocoo.org/5/python3/ and #1027

We need to log this error and possibly provide a prompt (solution) for the user.
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug needs PR labels Mar 30, 2018
@DonJayamanne DonJayamanne added this to the April 2018 milestone Mar 30, 2018
This was referenced Apr 10, 2018
Closed
Closed
@DonJayamanne DonJayamanne mentioned this issue Apr 18, 2018
Merged
5 tasks
DonJayamanne added a commit that referenced this issue Apr 18, 2018
@DonJayamanne
Capture and display errors returned by pipenv command (#1430)
a6267b7 
Fixes #1254
Fixes #1428
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@DonJayamanne DonJayamanne

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
April 2018
Development

Successfully merging a pull request may close this issue.

Capture and display errors returned by pipenv command DonJayamanne/pythonVSCode
2 participants
@brettcannon @DonJayamanne