Skip to content

Module installer is using the wrong pythonPath #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DonJayamanne opened this issue Mar 9, 2018 · 2 comments · Fixed by #1215
Closed

Module installer is using the wrong pythonPath #1015

DonJayamanne opened this issue Mar 9, 2018 · 2 comments · Fixed by #1215
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug good first issue
Milestone

Comments

@DonJayamanne
Copy link

Replace the following code in moduleInstaller.ts to use getActiveInterpreter

            const currentInterpreter = interpreters.length > 1
                ? interpreters.filter(x => fileSystem.arePathsSame(x.path, pythonPath))[0]
                : interpreters[0];
@DonJayamanne DonJayamanne added bug Issue identified by VS Code Team member as probable bug good first issue needs PR labels Mar 9, 2018
@DonJayamanne DonJayamanne added this to the March 2018 milestone Mar 9, 2018
@MikhailArkhipov MikhailArkhipov self-assigned this Mar 10, 2018
@MikhailArkhipov
Copy link

If not urgent, I got it fixed in vsc branch, but it may take some time before I am able to integrate.

@DonJayamanne
Copy link
Author

That's fine, if possible, please email me the fix ( i too can fix it, but easier this way, as you'll have less code merge conflicts)

@brettcannon brettcannon modified the milestones: March 2018, April 2018 Mar 27, 2018
DonJayamanne added a commit that referenced this issue Mar 30, 2018
* 🔨 use getActiveInterpreter to get active interpreter
* tests for module installer
* 📝 news entry
* Fixes #1015
@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants