Add support for extended Unicode escape sequences in strings and templates #2169
+2,787
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in separate functions.
…eSoManyWaysToDoIt
...because caps lock is cruise control for cool.
…eSoManyWaysToDoIt Conflicts: src/compiler/diagnosticInformationMap.generated.ts src/compiler/diagnosticMessages.json
| @@ -155,6 +155,8 @@ module ts { | |||
| Catch_clause_variable_name_must_be_an_identifier: { code: 1195, category: DiagnosticCategory.Error, key: "Catch clause variable name must be an identifier." }, | |||
| Catch_clause_variable_cannot_have_a_type_annotation: { code: 1196, category: DiagnosticCategory.Error, key: "Catch clause variable cannot have a type annotation." }, | |||
| Catch_clause_variable_cannot_have_an_initializer: { code: 1197, category: DiagnosticCategory.Error, key: "Catch clause variable cannot have an initializer." }, | |||
| An_extended_Unicode_escape_value_must_be_between_0x0_and_0x10FFFF_inclusive: { code: 1198, category: DiagnosticCategory.Error, key: "An extended Unicode escape value must be between 0x0 and 0x10FFFF inclusive." }, | |||
| expected: { code: 1199, category: DiagnosticCategory.Error, key: "'}' expected." }, | |||
There was a problem hiding this comment.
'Unterminated unicode escape'
…ix lookahead in text for numeric literal indicators.
DanielRosenwasser
added a commit
that referenced
this pull request
Mar 3, 2015
…ThereWouldntBeSoManyWaysToDoIt Add support for extended Unicode escape sequences in strings and templates
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2047.
ES6 extended escapes take the form of
\u{XXXXX...}whereXXXXX...is any number of hex digits. It is a syntax error if the value of these digits is greater than 0x10FFFF. When interpreting the value of such a code point, it must be interpreted as two individual UTF16 codepoints through a well-defined encoding scheme.Notable changes are:
\uXXXXescapes for any non-ASCII characters in the original string.\uXXXXescapes for any non-ASCII characters.Things we still don't support: