Update google_checks.xml for DPE modifications #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averikitsch
reviewed
Mar 20, 2020
| @@ -20,6 +20,7 @@ limitations under the License. | |||
| <suppressions> | |||
| <!-- For our tests we do not demand API documentation. --> | |||
| <suppress files=".*\.java" checks="Javadoc.*"/> | |||
| <suppress files=".*\.java" checks="CustomImportOrder" /> | |||
There was a problem hiding this comment.
Does this also allow any order for the imports as well as the newline?
There was a problem hiding this comment.
averikitsch
approved these changes
Mar 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #115 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 3 3
===========================================
Files 1 1
Lines 5 5
===========================================
Hits 5 5 Continue to review full report at Codecov.
|
* Add Averi * Remove CustomImportOrder suppresssion * Fix AppTest import order * Updates google_checks to have RegexpHeader, severity, SupressWarningsHolder, and SupressCommentFilter * Fix the METADATA
kurtisvg
approved these changes
Mar 24, 2020
averikitsch
approved these changes
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.