Skip to content

Rendering optimization and refactor #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 3, 2020

Conversation

RiugaBachi
Copy link
Contributor

:reimumug:

Sorry for the delays, kept my word in the end since I am (finally) feeling a bit better today.

e843993 contains a perfectly good IntMap-only implementation. I'm happy to submit another pull request tomorrow for a benchmark suite if that is something you would like to see. If there's ever a need for comparison between that and the current optimized approach, I would just branch from that commit and merge benchmarks + test suite.

@1Computer1
Copy link
Owner

A benchmark suite would be very nice if you have the time. Would it be the adhoc one you used, or an actual suite with criterion?

@1Computer1 1Computer1 linked an issue Oct 3, 2020 that may be closed by this pull request
- Imports are now in alphabetical order
- Tuple elements are now spaced
- Pragmas are now aligned
- Documented `slices` semantics
- Added a type signature for `slices`
- Documented `Monoid` superclass requirement for `Source`
- Removed redundant whitespace on long branching expressions
@RiugaBachi
Copy link
Contributor Author

A comprehensive one with criterion.

@RiugaBachi RiugaBachi requested a review from 1Computer1 October 3, 2020 05:14
@1Computer1
Copy link
Owner

That sounds great then. I'll take one last look over this in the morning and merge it then.

@1Computer1 1Computer1 merged commit 11b2d98 into 1Computer1:master Oct 3, 2020
@RiugaBachi RiugaBachi deleted the optimization branch October 3, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collect required lines instead of using them all
2 participants