-
Notifications
You must be signed in to change notification settings - Fork 6
Rendering optimization and refactor #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made `Monoid` a superclass of `Source`. - Every slice from `slices` now infinitely tails `mempty` to support out-of-bounds pointers.
1Computer1
requested changes
Oct 3, 2020
A benchmark suite would be very nice if you have the time. Would it be the adhoc one you used, or an actual suite with |
- Imports are now in alphabetical order - Tuple elements are now spaced - Pragmas are now aligned - Documented `slices` semantics - Added a type signature for `slices` - Documented `Monoid` superclass requirement for `Source` - Removed redundant whitespace on long branching expressions
A comprehensive one with |
That sounds great then. I'll take one last look over this in the morning and merge it then. |
1Computer1
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:reimumug:
Sorry for the delays, kept my word in the end since I am (finally) feeling a bit better today.
e843993 contains a perfectly good IntMap-only implementation. I'm happy to submit another pull request tomorrow for a benchmark suite if that is something you would like to see. If there's ever a need for comparison between that and the current optimized approach, I would just branch from that commit and merge benchmarks + test suite.