instrument functions: Add a length check

We need space for the '\0'.

This should fix Coverity CID 310985.

Moreover:
Use '\0' for the null character.

diff --git a/instrument-functions.c b/instrument-functions.c
index fb2314dd3f02c25561e9bca7b342b76192d10f37..aff33ccdc7e9f90d7354e81d2ade5fefae517e82 100644 (file)
--- a/instrument-functions.c
+++ b/instrument-functions.c
@@ -114,7 +114,12 @@ static void print_debug(void *this_fn, void *call_site, action_type action)
                        perror("failed to find executable\n");
                        return;
                }
-               pgm_name[ret] = 0;
+               if (ret == sizeof(pgm_name)) {
+                       /* no space for the '\0' */
+                       printf("truncation may have occurred\n");
+                       return;
+               }
+               pgm_name[ret] = '\0';
 
                bfd_init();