]> The Tcpdump Group git mirrors - tcpslice/commitdiff
instrument functions: Reduce the scope of a variable
authorFrancois-Xavier Le Bail <[email protected]>
Thu, 4 May 2023 11:24:06 +0000 (13:24 +0200)
committerFrancois-Xavier Le Bail <[email protected]>
Thu, 4 May 2023 11:24:06 +0000 (13:24 +0200)
Fix the cppcheck warning:
instrument-functions.c:77:15: warning: The scope of the variable
'instrument_type' can be reduced. [variableScope]

[skip ci]

instrument-functions.c

index 350a1682a0326f9a058e2f7369ff5320dcc01ce1..2c1ad3325bce1a468867e83fcc22a573b7ea432b 100644 (file)
@@ -74,13 +74,14 @@ static void print_debug(void *this_fn, void *call_site, action_type action)
        static long symcount;
        static asection *text;
        static bfd_vma vma;
-       static char *instrument_type;
        static int instrument_set;
        static int instrument_off;
        static int instrument_global;
        int i;
 
        if (!instrument_set) {
+               static char *instrument_type;
+
                /* Get the configuration environment variable INSTRUMENT value if any */
                instrument_type = getenv("INSTRUMENT");
                /* unset or set to an empty string ? */