From 26a4aa405a2d1b6fd9ee4c122abc5fb731e5f11e Mon Sep 17 00:00:00 2001 From: Denis Ovsienko Date: Fri, 21 Jul 2017 22:58:35 +0100 Subject: [PATCH] Frame Relay: denote a genuine fall through case MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The source code comment explains it should fall through but GCC does not pick it up, that's what the new macro is for. ./print-fr.c: In function ‘mfr_print’: ./print-fr.c:510:20: warning: this statement may fall through [-Wimplicit-fallthrough=] if (ie_len == sizeof(struct timeval)) { ^ ./print-fr.c:521:13: note: here case MFR_CTRL_IE_VENDOR_EXT: ^~~~ --- print-fr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/print-fr.c b/print-fr.c index da7ee25f..dad8173c 100644 --- a/print-fr.c +++ b/print-fr.c @@ -512,6 +512,7 @@ mfr_print(netdissect_options *ndo, break; } /* fall through and hexdump if no unix timestamp */ + ND_FALL_THROUGH; /* * FIXME those are the defined IEs that lack a decoder -- 2.39.5