]> The Tcpdump Group git mirrors - tcpdump/commit
OpenFlow 1.0: Improve handling of some lengths.
authorDenis Ovsienko <[email protected]>
Wed, 29 Dec 2021 21:06:25 +0000 (21:06 +0000)
committerDenis Ovsienko <[email protected]>
Wed, 29 Dec 2021 21:27:58 +0000 (21:27 +0000)
commit1ce16ea5770dca7e389d45b93411043714e6d8cc
treec66e9ca65ea3b0250d18fb60a96e781ca669d274
parentef5323efe6c03aaa50eac0949bf95999b91fe05b
OpenFlow 1.0: Improve handling of some lengths.

For OFPT_PACKET_OUT print "actions_len", as it is a part of the message
and should appear in its decoding (in other message types it is derived
from the message length).

ND_ICHECK_*() in of10_actions_print(), of10_flow_stats_reply_print() and
of10_packet_out_print() after printing at least some of the output.
This, compared to just "(invalid) (invalid)", makes it much easier to
understand  where and why the packet data was not fully decoded.  Define
OF_ACTION_MINLEN unsigned to squelch the induced compiler warnings.  A
number of similar checks still remain to be converted the same way.
print-openflow-1.0.c
tests/TESTLIST
tests/of10_inv_OFPST_FLOW-v.out [new file with mode: 0644]
tests/of10_inv_OFPST_FLOW.pcap [new file with mode: 0644]
tests/of10_s4810-vvvv.out