From: Francois-Xavier Le Bail Date: Tue, 22 Oct 2019 07:56:09 +0000 (+0200) Subject: RSVP: Add a test capture file X-Git-Tag: tcpdump-4.99-bp~641 X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/bc1e7f16e0ea13e271b38eb97722da7e1b7b1611 RSVP: Add a test capture file This capture file triggered a buffer over-read with the 4.9.2 release fixed in the 4.9.3 release. With the new GET_ macros, the problem no longer exists. Thus no fix needed. The pcap file was updated to pass the sanity checks and to avoid pcap_loop() error messages. Update the output of the test accordingly. Partial update from bea2686c296b79609060a104cc139810785b0739 in 4.9 branch. --- diff --git a/tests/TESTLIST b/tests/TESTLIST index ce8e0e77..68e8039d 100644 --- a/tests/TESTLIST +++ b/tests/TESTLIST @@ -608,6 +608,7 @@ isakmp-ikev1_n_print-oobr isakmp-ikev1_n_print-oobr.pcap isakmp-ikev1_n_print-oo ldp-ldp_tlv_print-oobr ldp-ldp_tlv_print-oobr.pcap ldp-ldp_tlv_print-oobr.out -v icmp-icmp_print-oobr-1 icmp-icmp_print-oobr-1.pcap icmp-icmp_print-oobr-1.out -v icmp-icmp_print-oobr-2 icmp-icmp_print-oobr-2.pcap icmp-icmp_print-oobr-2.out -v +rsvp-rsvp_obj_print-oobr rsvp-rsvp_obj_print-oobr.pcap rsvp-rsvp_obj_print-oobr.out -v # The .pcap file is truncated after the 1st packet. hncp_dhcpv6data-oobr hncp_dhcpv6data-oobr.pcap hncp_dhcpv6data-oobr.out -v -c1 hncp_dhcpv4data-oobr hncp_dhcpv4data-oobr.pcap hncp_dhcpv4data-oobr.out -v -c1 diff --git a/tests/rsvp-rsvp_obj_print-oobr.out b/tests/rsvp-rsvp_obj_print-oobr.out new file mode 100644 index 00000000..4cfa1f16 --- /dev/null +++ b/tests/rsvp-rsvp_obj_print-oobr.out @@ -0,0 +1,6 @@ + 1 03:21:36.131862 TIPC v5.0 226.0.0 > 64.14.1536, headerlength 56 bytes, MessageSize 51914 bytes, Link Changeover Protocol internal, messageType Unknown (0xcacacaca) [|tipc] + 2 [Invalid header: len==0] + 3 05:06:08.4043485718 IP (tos 0x0, ttl 14, id 44815, offset 0, flags [+, DF, rsvd], proto RSVP (46), length 40, bad cksum 3280 (->c411)!) + 250.219.91.71 > 20.100.238.255: + RSVPv1 Hello Message (20), Flags: [none], length: 16384, ttl: 0, checksum: 0x000e + Class Type (old) Object (125) Flags: [reject if unknown], Class-Type: 1 (1), length: 4 [|rsvp] diff --git a/tests/rsvp-rsvp_obj_print-oobr.pcap b/tests/rsvp-rsvp_obj_print-oobr.pcap new file mode 100644 index 00000000..bb794244 Binary files /dev/null and b/tests/rsvp-rsvp_obj_print-oobr.pcap differ