From: Francois-Xavier Le Bail <devel.fx.lebail@orange.fr>
Date: Wed, 3 May 2023 12:05:40 +0000 (+0200)
Subject: instrument functions: Reduce the scope of a variable
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/8e1661b4cd473be044a7d157227e28062b1c31b6

instrument functions: Reduce the scope of a variable

Fix the cppcheck warning:
instrument-functions.c:77:15: warning: The scope of the variable
'instrument_type' can be reduced. [variableScope]
---

diff --git a/instrument-functions.c b/instrument-functions.c
index 350a1682..2c1ad332 100644
--- a/instrument-functions.c
+++ b/instrument-functions.c
@@ -74,13 +74,14 @@ static void print_debug(void *this_fn, void *call_site, action_type action)
 	static long symcount;
 	static asection *text;
 	static bfd_vma vma;
-	static char *instrument_type;
 	static int instrument_set;
 	static int instrument_off;
 	static int instrument_global;
 	int i;
 
 	if (!instrument_set) {
+		static char *instrument_type;
+
 		/* Get the configuration environment variable INSTRUMENT value if any */
 		instrument_type = getenv("INSTRUMENT");
 		/* unset or set to an empty string ? */