From: Guy Harris <guy@alum.mit.edu>
Date: Mon, 28 Dec 2015 02:09:33 +0000 (-0800)
Subject: If HAVE_LIBCRYPTO isn't defined, define a stub signature_verify().
X-Git-Tag: tcpdump-4.8.0~49
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/7b1cba646d765868d21e7c66af54ed06f2a739b7

If HAVE_LIBCRYPTO isn't defined, define a stub signature_verify().

That cleans up its callers.
---

diff --git a/print-isoclns.c b/print-isoclns.c
index f2903941..2cbb3301 100644
--- a/print-isoclns.c
+++ b/print-isoclns.c
@@ -2667,13 +2667,9 @@ isis_print(netdissect_options *ndo,
 		if (tlv_len != ISIS_SUBTLV_AUTH_MD5_LEN+1)
                     ND_PRINT((ndo, ", (invalid subTLV) "));
 
-#ifdef HAVE_LIBCRYPTO
                 sigcheck = signature_verify(ndo, optr, length, tptr + 1,
                                             isis_clear_checksum_lifetime,
                                             header_lsp);
-#else
-                sigcheck = CANT_CHECK_SIGNATURE;
-#endif
                 ND_PRINT((ndo, " (%s)", tok2str(signature_check_values, "Unknown", sigcheck)));
 
 		break;
diff --git a/print-rsvp.c b/print-rsvp.c
index 17263377..6e1acd67 100644
--- a/print-rsvp.c
+++ b/print-rsvp.c
@@ -654,21 +654,9 @@ rsvp_clear_checksum(void *header)
 
 static int
 rsvp_obj_print(netdissect_options *ndo,
-               const u_char *pptr
-#ifndef HAVE_LIBCRYPTO
-_U_
-#endif
-, u_int plen
-#ifndef HAVE_LIBCRYPTO
-_U_
-#endif
-, const u_char *tptr,
-                const char *ident, u_int tlen,
-                const struct rsvp_common_header *rsvp_com_header
-#ifndef HAVE_LIBCRYPTO
-_U_
-#endif
-)
+               const u_char *pptr, u_int plen, const u_char *tptr,
+               const char *ident, u_int tlen,
+               const struct rsvp_common_header *rsvp_com_header)
 {
     const struct rsvp_object_header *rsvp_obj_header;
     const u_char *obj_tptr;
@@ -1682,14 +1670,10 @@ _U_
                        EXTRACT_32BITS(obj_ptr.rsvp_obj_integrity->digest+8),
                        EXTRACT_32BITS(obj_ptr.rsvp_obj_integrity->digest + 12)));
 
-#ifdef HAVE_LIBCRYPTO
                 sigcheck = signature_verify(ndo, pptr, plen,
                                             obj_ptr.rsvp_obj_integrity->digest,
                                             rsvp_clear_checksum,
                                             rsvp_com_header);
-#else
-                sigcheck = CANT_CHECK_SIGNATURE;
-#endif
                 ND_PRINT((ndo, " (%s)", tok2str(signature_check_values, "Unknown", sigcheck)));
 
                 obj_tlen+=sizeof(struct rsvp_obj_integrity_t);
diff --git a/signature.c b/signature.c
index 77ec493b..c97b8534 100644
--- a/signature.c
+++ b/signature.c
@@ -109,9 +109,7 @@ signature_compute_hmac_md5(const uint8_t *text, int text_len, unsigned char *key
     MD5_Final(digest, &context);          /* finish up 2nd pass */
 }
 USES_APPLE_RST
-#endif
 
-#ifdef HAVE_LIBCRYPTO
 /*
  * Verify a cryptographic signature of the packet.
  * Currently only MD5 is supported.
@@ -198,6 +196,14 @@ signature_verify(netdissect_options *ndo, const u_char *pptr, u_int plen,
         return (SIGNATURE_INVALID);
     }
 }
+#else
+int
+signature_verify(netdissect_options *ndo _U_, const u_char *pptr _U_,
+                 u_int plen _U_, const u_char *sig_ptr _U_,
+                 void (*clear_rtn)(void *) _U_, const void *clear_arg _U_)
+{
+    return (CANT_CHECK_SIGNATURE);
+}
 #endif
 
 /*