From: Denis Ovsienko <infrastation@yandex.ru>
Date: Thu, 19 Dec 2013 14:00:16 +0000 (+0400)
Subject: IPv6: use unsigned mobility vars (GH #47 pt. 2)
X-Git-Tag: tcpdump-4.6.0~321
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/57c538422b7fcde95be3df88912f13a792ce7ccc?ds=sidebyside;hp=4ae4df98b29a96980cd33cd48cb99d58a6060725

IPv6: use unsigned mobility vars (GH #47 pt. 2)
---

diff --git a/print-mobility.c b/print-mobility.c
index 752dcd73..21e3cedf 100644
--- a/print-mobility.c
+++ b/print-mobility.c
@@ -89,10 +89,9 @@ struct ip6_mobility {
 #define IP6MOPT_AUTH_MINLEN    12
 
 static void
-mobility_opt_print(const u_char *bp, int len)
+mobility_opt_print(const u_char *bp, const unsigned len)
 {
-	int i;
-	int optlen;
+	unsigned i, optlen;
 
 	for (i = 0; i < len; i += optlen) {
 		if (bp[i] == IP6MOPT_PAD1)
@@ -172,7 +171,8 @@ mobility_print(const u_char *bp, const u_char *bp2 _U_)
 {
 	const struct ip6_mobility *mh;
 	const u_char *ep;
-	int mhlen, hlen, type;
+	unsigned mhlen, hlen;
+	u_int8_t type;
 
 	mh = (struct ip6_mobility *)bp;
 
@@ -195,7 +195,7 @@ mobility_print(const u_char *bp, const u_char *bp2 _U_)
 		mhlen = ep - bp;
 		goto trunc;
 	}
-	mhlen = (int)((mh->ip6m_len + 1) << 3);
+	mhlen = (mh->ip6m_len + 1) << 3;
 
 	/* XXX ip6m_cksum */