From: Guy Harris <gharris@sonic.net>
Date: Tue, 22 Aug 2023 20:57:19 +0000 (-0700)
Subject: pgm: expand the comment about PGMCC ACKs. [skip ci]
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/57a7eaecb12d1965de568b9208c663bb09b2fc32?ds=sidebyside;hp=-c

pgm: expand the comment about PGMCC ACKs. [skip ci]

Apparently there is at least one implementation (Luigi Risso's) that
uses 0x0b for ACK, and at least one implementation (OpenPGM) that uses
0x0d for ACK.
---

57a7eaecb12d1965de568b9208c663bb09b2fc32
diff --git a/print-pgm.c b/print-pgm.c
index c62fd03e..23212992 100644
--- a/print-pgm.c
+++ b/print-pgm.c
@@ -25,9 +25,27 @@
    an *insufficient* description of said changes.  In particular,
    it doesn't indicate what the packet type code for ACK is.
 
-   This uses 0x0b as the packet type code; Wireshark uses 0x0d.
-   At least one capture appears to use 0x0d, so we use *both*,
-   treating *either one* as a PGMCC ACK. */
+   Luigi Risso's PGMCC code for FreeBSD, at
+
+      https://web.archive.org/web/20020302084503/http://info.iet.unipi.it/~luigi/pgm-code/
+
+   uses 0x0b (11) for ACK.
+
+   A capture file attached to
+
+      https://gitlab.com/wireshark/wireshark/-/issues/4798
+
+   has packets that use 0x0d for ACK, as does the Wireshark dissector
+   for PGM, and as does OpenPGM at https://github.com/steve-o/openpgm.
+   It may be that some proprietary PGMCC implementations, such as
+   SmartPGM, do so as well.
+
+   We use *both*, treating *either one* as a PGMCC ACK, pending
+   more information, such as an answer to
+
+      https://github.com/steve-o/openpgm/issues/75.
+
+   */
 
 #ifdef HAVE_CONFIG_H
 #include <config.h>