From: Guy Harris Date: Wed, 5 Feb 2020 04:07:44 +0000 (-0800) Subject: Do the isis-seg-fault-1-v test regardless of the floating-point type. X-Git-Tag: tcpdump-4.99-bp~550 X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/40e38a38378ccb014e7713d38eb9b45af3968919 Do the isis-seg-fault-1-v test regardless of the floating-point type. This test seems to work even with "x87" floating point; perhaps it fails on, e.g., SPARC with some compiler. --- diff --git a/tests/isis-seg-fault-1-v.tests b/tests/isis-seg-fault-1-v.tests index 7d3714ef..6d4eec5d 100644 --- a/tests/isis-seg-fault-1-v.tests +++ b/tests/isis-seg-fault-1-v.tests @@ -5,10 +5,14 @@ # the version of the instruction set for which it's generating code (see # GitHub issue #333 for another example). The test is done only if we have # a floating-point type, as reported by "./tcpdump --fp-type", of FPTYPE1. +# +# XXX - this works on my 32-bit x86 Linux virtual machine, so do this +# regardless of the floating-point type, so always do this. If it +# fails on some platform, we'll need to tweak tcpdump and tests/TESTrun +# to check for *that* floating-point difference. $testlist = [ { - config_set => 'HAVE_FPTYPE1', name => 'isis-seg-fault-1-v', input => 'isis-seg-fault-1.pcapng', output => 'isis-seg-fault-1-v.out',