From: Francois-Xavier Le Bail <devel.fx.lebail@orange.fr>
Date: Wed, 30 Sep 2020 08:48:04 +0000 (+0200)
Subject: RX: Remove 1 now redundant ND_TCHECK_LEN(e, sizeof(uint32_t)) call
X-Git-Tag: tcpdump-4.99-bp~181
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/3435ef98e5c1552d9f1f184188260092d1ca7774

RX: Remove 1 now redundant ND_TCHECK_LEN(e, sizeof(uint32_t)) call

it is redundant because it is identical to ND_TCHECK_4(e), followed
by a GET_BE_U_4(e), same e, which do the bounds check.
---

diff --git a/print-rx.c b/print-rx.c
index 7dfa3ddb..3b7a623d 100644
--- a/print-rx.c
+++ b/print-rx.c
@@ -766,7 +766,6 @@ rx_cache_find(netdissect_options *ndo, const struct rx_header *rxh,
 		}
 
 #define STROUT(MAX) { uint32_t _i; \
-			ND_TCHECK_LEN(bp, sizeof(uint32_t)); \
 			_i = GET_BE_U_4(bp); \
 			if (_i > (MAX)) \
 				goto trunc; \