From: Denis Ovsienko <denis@ovsienko.info>
Date: Fri, 21 Jul 2017 21:58:35 +0000 (+0100)
Subject: Frame Relay: denote a genuine fall through case
X-Git-Tag: tcpdump-4.99-bp~2044
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/26a4aa405a2d1b6fd9ee4c122abc5fb731e5f11e

Frame Relay: denote a genuine fall through case

The source code comment explains it should fall through but GCC does not
pick it up, that's what the new macro is for.

./print-fr.c: In function ‘mfr_print’:
./print-fr.c:510:20: warning: this statement may fall through [-Wimplicit-fallthrough=]
                 if (ie_len == sizeof(struct timeval)) {
                    ^
./print-fr.c:521:13: note: here
             case MFR_CTRL_IE_VENDOR_EXT:
             ^~~~
---

diff --git a/print-fr.c b/print-fr.c
index da7ee25f..dad8173c 100644
--- a/print-fr.c
+++ b/print-fr.c
@@ -512,6 +512,7 @@ mfr_print(netdissect_options *ndo,
                     break;
                 }
                 /* fall through and hexdump if no unix timestamp */
+                ND_FALL_THROUGH;
 
                 /*
                  * FIXME those are the defined IEs that lack a decoder