From: Francois-Xavier Le Bail Date: Mon, 21 Oct 2019 15:21:12 +0000 (+0200) Subject: LDP: Add a test capture file X-Git-Tag: tcpdump-4.99-bp~644 X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/1b428d2dca964cc7a1696559b293749e738c3939 LDP: Add a test capture file This capture file triggered a buffer over-read with the 4.9.2 release fixed in the 4.9.3 release. With the new GET_ macros, the problem no longer exists. Thus no fix needed. The pcap file was updated to avoid pcap_loop() error messages. Update the output of the test accordingly. Partial update from aa5c6b710dfd8020d2c908d6b3bd41f1da719b3b in 4.9 branch. --- diff --git a/tests/TESTLIST b/tests/TESTLIST index 0017d99c..b297176f 100644 --- a/tests/TESTLIST +++ b/tests/TESTLIST @@ -605,6 +605,7 @@ ospf6_decode_v3_asan ospf6_decode_v3_asan.pcap ospf6_decode_v3_asan.out -v ip_ts_opts_asan ip_ts_opts_asan.pcap ip_ts_opts_asan.out -v isakmpv1-attr-oobr isakmpv1-attr-oobr.pcap isakmpv1-attr-oobr.out -v isakmp-ikev1_n_print-oobr isakmp-ikev1_n_print-oobr.pcap isakmp-ikev1_n_print-oobr.out -v +ldp-ldp_tlv_print-oobr ldp-ldp_tlv_print-oobr.pcap ldp-ldp_tlv_print-oobr.out -v # The .pcap file is truncated after the 1st packet. hncp_dhcpv6data-oobr hncp_dhcpv6data-oobr.pcap hncp_dhcpv6data-oobr.out -v -c1 hncp_dhcpv4data-oobr hncp_dhcpv4data-oobr.pcap hncp_dhcpv4data-oobr.out -v -c1 diff --git a/tests/ldp-ldp_tlv_print-oobr.out b/tests/ldp-ldp_tlv_print-oobr.out new file mode 100644 index 00000000..d1e64c8e --- /dev/null +++ b/tests/ldp-ldp_tlv_print-oobr.out @@ -0,0 +1,7 @@ + 1 [Error converting time] IP (tos 0x0, id 4608, offset 0, flags [+, DF, rsvd], proto UDP (17), length 25600, options (EOL), bad cksum 8e (->4023)!) + 24.250.219.0.4098 > 0.0.0.0.646: + LDP, Label-Space-ID: 0.0.127.255:796, pdu-length: 514 + Address Withdraw Message (0x0301), length: 22, Message ID: 0x00001600, Flags: [ignore if unknown] + Unknown TLV (0x0404), length: 0, Flags: [ignore and don't forward if unknown] + Fault-Tolerant Session Parameters TLV (0x0503), length: 8, Flags: [ignore and don't forward if unknown] + Flags: [No Reconnect, Don't Save State, No All-Label Protection, Sequence Numbered Label Checkpoint, Re-Learn State], Reconnect Timeout: 50331648ms [|ldp] diff --git a/tests/ldp-ldp_tlv_print-oobr.pcap b/tests/ldp-ldp_tlv_print-oobr.pcap new file mode 100644 index 00000000..82ddad73 Binary files /dev/null and b/tests/ldp-ldp_tlv_print-oobr.pcap differ