From: Francois-Xavier Le Bail <devel.fx.lebail@orange.fr>
Date: Sun, 6 Feb 2022 19:54:50 +0000 (+0100)
Subject: ICMPv6: Add a comment about "don't use GET_IP6ADDR_STRING()"
X-Git-Tag: tcpdump-4.99.2~74
X-Git-Url: https://git.tcpdump.org/tcpdump/commitdiff_plain/0a3b5b02220be944d054eec4b44ae2ed70609c88

ICMPv6: Add a comment about "don't use GET_IP6ADDR_STRING()"

[skip ci]

(cherry picked from commit b34f18bdffd263ae544e370c048238a90179e877)
---

diff --git a/print-icmp6.c b/print-icmp6.c
index 0ba65690..f380be20 100644
--- a/print-icmp6.c
+++ b/print-icmp6.c
@@ -1520,7 +1520,7 @@ icmp6_opt_print(netdissect_options *ndo, const u_char *bp, int resid)
 			default:
 				goto trunc;
 			}
-			ND_PRINT(" %s/%u", ip6addr_string(ndo, (const u_char *)&in6),
+			ND_PRINT(" %s/%u", ip6addr_string(ndo, (const u_char *)&in6), /* local buffer, not packet data; don't use GET_IP6ADDR_STRING() */
                                   GET_U_1(opri->nd_opt_rti_prefixlen));
 			ND_PRINT(", pref=%s",
 				 get_rtpref(GET_U_1(opri->nd_opt_rti_flags)));