]> The Tcpdump Group git mirrors - tcpdump/commitdiff
LISP: Fix a Clang warning
authorFrancois-Xavier Le Bail <[email protected]>
Mon, 5 Oct 2015 09:03:15 +0000 (11:03 +0200)
committerFrancois-Xavier Le Bail <[email protected]>
Mon, 5 Oct 2015 09:29:35 +0000 (11:29 +0200)
The warning was:
./print-lisp.c:401:11: warning: variable 'xtr_present' is used uninitialized
      whenever 'if' condition is false [-Wsometimes-uninitialized]
        else if (type == LISP_MAP_NOTIFY)
                 ^~~~~~~~~~~~~~~~~~~~~~~

./print-lisp.c:404:9: note: uninitialized use occurs here
        return xtr_present;
               ^~~~~~~~~~~

Moreover:
Remove unused 'interface.h' include.

print-lisp.c

index ddddc2e9a2e8b66d24172475b82cdfc710ddcf54..6b5b8151ce1c87ecf1b2966eb7b13d74c9bf8d49 100644 (file)
 #include "ip6.h"
 
 #include "extract.h"
-#include "interface.h"
 #include "addrtoname.h"
 
 #define IPv4_AFI                       1
@@ -394,7 +393,7 @@ static inline uint8_t extract_lisp_type(uint8_t lisp_hdr_flags)
 
 static inline uint8_t is_xtr_data_present(uint8_t type, uint8_t lisp_hdr_flags)
 {
-       uint8_t xtr_present;
+       uint8_t xtr_present = 0;
 
        if (type == LISP_MAP_REGISTER)
                xtr_present = (lisp_hdr_flags) & LISP_MAP_REGISTER_IBIT_MASK;