]> The Tcpdump Group git mirrors - tcpdump/commitdiff
print-ntp.c: Add and use VERSIONSHIFT
authorUlrich Windl <[email protected]>
Wed, 23 Aug 2017 12:42:57 +0000 (14:42 +0200)
committerDenis Ovsienko <[email protected]>
Tue, 29 Aug 2017 13:45:24 +0000 (14:45 +0100)
Add shift constant VERSIONSHIFT(3), and use it in ntp_print().

print-ntp.c

index f38862f447b01427dc211a4729a946365fca9bf1..e2a59240dfc8804391dc400c4fed038a2b3c310d 100644 (file)
@@ -141,6 +141,7 @@ struct ntpdata {
  */
 #define        NTPVERSION_1    0x08
 #define        VERSIONMASK     0x38
+#define        VERSIONSHIFT    3
 #define LEAPMASK       0xc0
 #ifdef MODEMASK
 #undef MODEMASK                                        /* Solaris sucks */
@@ -212,7 +213,7 @@ ntp_print(netdissect_options *ndo,
 
        ND_TCHECK(bp->status);
 
-       version = (int)(bp->status & VERSIONMASK) >> 3;
+       version = (int)(bp->status & VERSIONMASK) >> VERSIONSHIFT;
        ND_PRINT((ndo, "NTPv%d", version));
 
        mode = bp->status & MODEMASK;