Fix off-by-one error in print-rx.c

Avoid dereferencing rx_cache[RX_CACHE_SIZE], which is one past the last
valid element.

(This fixes SF bug 3599633 / GH bug 287. I could not identify the name
or email address of the original contributor. -- Denis)

diff --git a/print-rx.c b/print-rx.c
index 70393ea5cbbe2c290971d012a349d81f74edde1d..383ef3713ffc17aea18a701e572910a01b145c05 100644 (file)
--- a/print-rx.c
+++ b/print-rx.c
@@ -653,7 +653,7 @@ rx_cache_find(const struct rx_header *rxh, const struct ip *ip, int sport,
                        *opcode = rxent->opcode;
                        return(1);
                }
-               if (++i > RX_CACHE_SIZE)
+               if (++i >= RX_CACHE_SIZE)
                        i = 0;
        } while (i != rx_cache_hint);