]> The Tcpdump Group git mirrors - tcpdump/commitdiff
initialize a structure in print-juniper.c
authorDenis Ovsienko <[email protected]>
Sat, 8 Oct 2016 15:15:06 +0000 (16:15 +0100)
committerDenis Ovsienko <[email protected]>
Sat, 8 Oct 2016 15:15:06 +0000 (16:15 +0100)
This should resolve a Coverity warning:

CID 702208 (#1 of 1): Uninitialized scalar variable (UNINIT)
2. uninit_use_in_call: Using uninitialized element of array
"l2info.cookie" when calling "juniper_parse_header"

print-juniper.c

index a9a9339a722c0344ed1fb578e48a9c842fc2a49e..2fc5bea6de198d96ff17b34ea61e8315ad95814d 100644 (file)
@@ -28,6 +28,8 @@ __RCSID("NetBSD: print-juniper.c,v 1.3 2007/07/25 06:31:32 dogcow Exp ");
 
 #include <netdissect-stdinc.h>
 
+#include <string.h>
+
 #include "netdissect.h"
 #include "addrtoname.h"
 #include "extract.h"
@@ -819,6 +821,7 @@ juniper_mfr_print(netdissect_options *ndo,
 {
         struct juniper_l2info_t l2info;
 
+        memset(&l2info, 0, sizeof(l2info));
         l2info.pictype = DLT_JUNIPER_MFR;
         if (juniper_parse_header(ndo, p, h, &l2info) == 0)
             return l2info.header_len;