]> The Tcpdump Group git mirrors - tcpdump/commitdiff
Use symmetrical quotation characters in error messages
authorFrancois-Xavier Le Bail <[email protected]>
Thu, 9 Nov 2023 18:41:22 +0000 (19:41 +0100)
committerFrancois-Xavier Le Bail <[email protected]>
Thu, 16 Nov 2023 16:07:37 +0000 (17:07 +0100)
Symmetrical quoting looks better.

Thus s/`/'/

See '5.10 Quote Characters' in GNU Coding Standards:

https://www.gnu.org/prep/standards/standards.html#Quote-Characters

(cherry picked from commit 262e119454d1e6e2121435cba3c47f34dbac0df4)

[skip ci]

CHANGES
tcpdump.c

diff --git a/CHANGES b/CHANGES
index c6180ea76c8f69f4ee89caf402bbcf9ca935e678..4b8c750276612d59057d64c901f5fc98b6cb7763 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -40,6 +40,7 @@ DayOfTheWeek, Month DD, YYYY / The Tcpdump Group
     User interface:
       Print the supported time stamp types (-J) to stdout instead of stderr.
       Print the list of data link types (-L) to stdout instead of stderr.
+      Use symmetrical quotation characters in error messages.
     Source code:
       tcpdump: Fix a memory leak.
       child_cleanup: reap as many child processes as possible.
index e8c6b816281b63df089014c67f62af51ba097355..633d4812d0e5379f41f5542705aa4f1ea34c80cb 100644 (file)
--- a/tcpdump.c
+++ b/tcpdump.c
@@ -1728,7 +1728,7 @@ main(int argc, char **argv)
                                if (nd_load_smi_module(optarg, ebuf, sizeof(ebuf)) == -1)
                                        error("%s", ebuf);
                        } else {
-                               (void)fprintf(stderr, "%s: ignoring option `-m %s' ",
+                               (void)fprintf(stderr, "%s: ignoring option '-m %s' ",
                                              program_name, optarg);
                                (void)fprintf(stderr, "(no libsmi support)\n");
                        }
@@ -1772,7 +1772,7 @@ main(int argc, char **argv)
                        else if (ascii_strcasecmp(optarg, "inout") == 0)
                                Qflag = PCAP_D_INOUT;
                        else
-                               error("unknown capture direction `%s'", optarg);
+                               error("unknown capture direction '%s'", optarg);
                        break;
 #endif /* HAVE_PCAP_SETDIRECTION */
 
@@ -1838,7 +1838,7 @@ main(int argc, char **argv)
                        else if (ascii_strcasecmp(optarg, "domain") == 0)
                                ndo->ndo_packettype = PT_DOMAIN;
                        else
-                               error("unknown packet type `%s'", optarg);
+                               error("unknown packet type '%s'", optarg);
                        break;
 
                case 'u':