Rx: Fix remaining fall-through warnings (GH #618).

Benjamin Kaduk explains in the issue comments:

The first two ("bulk stat" and "callback"; lines 1023 and 1282) should
not fall through, but the other two ("list entry" in various forms,
lines 1741 and 1790) should fall through. The answer lies in the RPC-L
files at [1], [2] and [3] (also line 396), looking at the appropriate IN
or OUT arguments.

1: http://git.openafs.org/?p=openafs.git;a=blob;f=src/fsint/afsint.xg;h=9fe4980c6cffcae457789e363393825e29dcb7b1;hb=HEAD#l594
2: http://git.openafs.org/?p=openafs.git;a=blob;f=src/fsint/afscbint.xg;h=19760bc512c647595662c30e190303b3a20be983;hb=HEAD#l22
3: http://git.openafs.org/?p=openafs.git;a=blob;f=src/vlserver/vldbint.xg;h=ff34d12d45454de328439cab3ed896fd564f0c59;hb=HEAD#l341

diff --git a/print-rx.c b/print-rx.c
index 454ae4ff0339ba1e35a1af99e47606aead9c62d8..0eaca18944ef291468e83da92330c0a5b80251d6 100644 (file)
--- a/print-rx.c
+++ b/print-rx.c
@@ -1023,6 +1023,7 @@ fs_print(netdissect_options *ndo,
                        }
                        if (j == 0)
                                ND_PRINT(" <none!>");
+                       break;
                }
                case 65537:     /* Fetch data 64 */
                        FIDOUT();
@@ -1284,6 +1285,7 @@ cb_print(netdissect_options *ndo,
                                bp += sizeof(uint32_t);
                                tok2str(cb_types, "type %u", t);
                        }
+                       break;
                }
                case 214: {
                        ND_PRINT(" afsuuid");
@@ -1745,6 +1747,7 @@ vldb_reply_print(netdissect_options *ndo,
                        INTOUT();
                        ND_PRINT(" nextindex");
                        INTOUT();
+                       ND_FALL_THROUGH;
                case 503:       /* Get entry by id */
                case 504:       /* Get entry by name */
                {       uint32_t nservers, j;
@@ -1794,6 +1797,7 @@ vldb_reply_print(netdissect_options *ndo,
                        INTOUT();
                        ND_PRINT(" nextindex");
                        INTOUT();
+                       ND_FALL_THROUGH;
                case 518:       /* Get entry by ID N */
                case 519:       /* Get entry by name N */
                {       uint32_t nservers, j;