Get rid of dead code.

The loop runs until total_subobj_len is 0, so it'll always be zero if we
exit the loop normally, and the test of whether it's non-zero will
always fail.

Fixes Coverity CID 1427591.

diff --git a/print-rsvp.c b/print-rsvp.c
index 8d89abf43fb3300024628ab67c7583e6d77f568f..12b51f27f46d35a0aa94944dc36e1a72beeb08aa 100644 (file)
--- a/print-rsvp.c
+++ b/print-rsvp.c
@@ -1329,11 +1329,6 @@ rsvp_obj_print(netdissect_options *ndo,
                     obj_tptr+=subobj_len;
                     obj_tlen+=subobj_len;
                }
-
-                if (total_subobj_len) {
-                    /* unless we have a TLV parser lets just hexdump */
-                    hexdump=TRUE;
-                }
                 break;
 
             default: