Point people to the autoconf documentation on shell substitution.

Hopefully this will keep people from sending "helpful" patches that
break things.

diff --git a/aclocal.m4 b/aclocal.m4
index 91896b340738e334b17612a6e7f64f3e75c44f22..ce746a87e9c6c5fe7d59cdb088803636bb66e46d 100644 (file)
--- a/aclocal.m4
+++ b/aclocal.m4
@@ -315,6 +315,13 @@ AC_DEFUN(AC_LBL_LIBPCAP,
                # Found - use it to get the include flags for
                # libpcap and the flags to link with libpcap.
                #
                # Found - use it to get the include flags for
                # libpcap and the flags to link with libpcap.
                #

+               # Please read section 11.6 "Shell Substitutions"
+               # in the autoconf manual before doing anything
+               # to this that involves quoting.  Especially note
+               # the statement "There is just no portable way to use
+               # double-quoted strings inside double-quoted back-quoted
+               # expressions (pfew!)."
+               #

                cflags=`"$PCAP_CONFIG" --cflags`
                $2="$cflags $$2"
                libpcap=`"$PCAP_CONFIG" --libs`
                cflags=`"$PCAP_CONFIG" --cflags`
                $2="$cflags $$2"
                libpcap=`"$PCAP_CONFIG" --libs`


@@ -379,7 +386,14 @@ AC_DEFUN(AC_LBL_LIBPCAP,
                # The libpcap directory has a pcap-config script.
                # Use it to get any additioal libraries needed
                # to link with the libpcap archive library in
                # The libpcap directory has a pcap-config script.
                # Use it to get any additioal libraries needed
                # to link with the libpcap archive library in

-               # that directory
+               # that directory.
+               #
+               # Please read section 11.6 "Shell Substitutions"
+               # in the autoconf manual before doing anything
+               # to this that involves quoting.  Especially note
+               # the statement "There is just no portable way to use
+               # double-quoted strings inside double-quoted back-quoted
+               # expressions (pfew!)."

                #
                additional_libs=`"$PCAP_CONFIG" --additional-libs --static`
                libpcap="$libpcap $additional_libs"
                #
                additional_libs=`"$PCAP_CONFIG" --additional-libs --static`
                libpcap="$libpcap $additional_libs"

diff --git a/configure b/configure
index 5c1bf2753c5850188ddd26e157400c61852f3cd0..b6cc137422115882db2f226b618a33dbdacc4094 100755 (executable)
--- a/configure
+++ b/configure
@@ -7579,6 +7579,13 @@ fi
                # Found - use it to get the include flags for
                # libpcap and the flags to link with libpcap.
                #
                # Found - use it to get the include flags for
                # libpcap and the flags to link with libpcap.
                #

+               # Please read section 11.6 "Shell Substitutions"
+               # in the autoconf manual before doing anything
+               # to this that involves quoting.  Especially note
+               # the statement "There is just no portable way to use
+               # double-quoted strings inside double-quoted back-quoted
+               # expressions (pfew!)."
+               #

                cflags=`"$PCAP_CONFIG" --cflags`
                V_INCLS="$cflags $V_INCLS"
                libpcap=`"$PCAP_CONFIG" --libs`
                cflags=`"$PCAP_CONFIG" --cflags`
                V_INCLS="$cflags $V_INCLS"
                libpcap=`"$PCAP_CONFIG" --libs`


@@ -7729,7 +7736,14 @@ fi
                # The libpcap directory has a pcap-config script.
                # Use it to get any additioal libraries needed
                # to link with the libpcap archive library in
                # The libpcap directory has a pcap-config script.
                # Use it to get any additioal libraries needed
                # to link with the libpcap archive library in

-               # that directory
+               # that directory.
+               #
+               # Please read section 11.6 "Shell Substitutions"
+               # in the autoconf manual before doing anything
+               # to this that involves quoting.  Especially note
+               # the statement "There is just no portable way to use
+               # double-quoted strings inside double-quoted back-quoted
+               # expressions (pfew!)."

                #
                additional_libs=`"$PCAP_CONFIG" --additional-libs --static`
                libpcap="$libpcap $additional_libs"
                #
                additional_libs=`"$PCAP_CONFIG" --additional-libs --static`
                libpcap="$libpcap $additional_libs"