Include <time.h> from netdissect.h.

netdissect.h since commit 7578e1c requires <time.h> for struct tm.  The
dependency is difficult to notice because the warning pops up when
compiling strdup.c only and only on Linux, and Linux most certainly has
strdup(), so normally strdup.c is never compiled on Linux.  Make it
correct anyway to eliminate a space for future surprises in other files.

$ make strdup.o
In file included from ./missing/strdup.c:38:
./netdissect.h:441:38: warning: 'struct tm' declared inside parameter
  list will not be visible outside of this definition or declaration

gcc (Debian 10.2.1-6) 10.2.1 20210110

(backported from commit 695ce83d0ad8eeaec1e1dec218279ac2d2168189)

diff --git a/netdissect.h b/netdissect.h
index 077ae3968b1af88dae8fe1ed3cf212cd5e9c12e5..9dc70db0a0fd02d15da535aad0651b566905e03b 100644 (file)
--- a/netdissect.h
+++ b/netdissect.h
@@ -30,6 +30,7 @@
 #endif
 #include <sys/types.h>
 #include <setjmp.h>
+#include <time.h>
 #include "status-exit-codes.h"
 #include "funcattrs.h" /* for PRINTFLIKE_FUNCPTR() */
 #include "diag-control.h" /* for ND_UNREACHABLE */

diff --git a/print-ntp.c b/print-ntp.c
index 537975cc2e593b798b72d5985c58bbf4c1ee0b63..92e3e297124031320be00015707119533a7a6fa1 100644 (file)
--- a/print-ntp.c
+++ b/print-ntp.c
@@ -38,8 +38,6 @@
 
 #include "netdissect-stdinc.h"
 
-#include <time.h>
-
 #include "netdissect.h"
 #include "addrtoname.h"
 #include "extract.h"