]> The Tcpdump Group git mirrors - tcpdump/commitdiff
Add a comment asking what the heck is going on here.
authorGuy Harris <[email protected]>
Mon, 27 Apr 2015 00:17:20 +0000 (17:17 -0700)
committerGuy Harris <[email protected]>
Mon, 27 Apr 2015 00:17:20 +0000 (17:17 -0700)
It's fetching a checksum field directly, rather than with
EXTRACT_16BITS().

print-vjc.c

index fc7aafa946c1aef2737384a26ce825c1e59307d7..0023af8bcaa0b3832be8804accd3419927fecb44 100644 (file)
  * We therefore leave "proto" - which is the PPP protocol type - in place,
  * *not* marked as unused, for now, so that GCC warnings about the
  * unused argument remind us that we should fix this some day.
+ *
+ * XXX - also, it fetches the TCP checksum field in COMPRESSED_TCP
+ * packets directly, rather than with EXTRACT_16BITS(); RFC 1144 says
+ * it's "the unmodified TCP checksum", which would imply that it's
+ * big-endian, but perhaps, on the platform where this was developed,
+ * the packets were munged by the networking stack before being handed
+ * to the packet capture mechanism.
  */
 int
 vjc_print(netdissect_options *ndo, register const char *bp, u_short proto _U_)