]> The Tcpdump Group git mirrors - tcpdump/commitdiff
add two missing breaks to print-bgp.c
authorDenis Ovsienko <[email protected]>
Thu, 6 Oct 2016 21:56:51 +0000 (22:56 +0100)
committerDenis Ovsienko <[email protected]>
Thu, 6 Oct 2016 22:02:03 +0000 (23:02 +0100)
This fixes one valid Coverity report and two bugs, which would cause
erroneous extra output on a BGP NOTIFICATION message decoding.

print-bgp.c

index 067ce2b4947bb40f2257ba13a5b86bd3c4770715..d00cd8ad6b26ac489b2cd09ad12e6a85a626503d 100644 (file)
@@ -2630,11 +2630,13 @@ bgp_notification_print(netdissect_options *ndo,
                   tok2str(bgp_notify_minor_fsm_values, "Unknown",
                              bgpn.bgpn_minor),
                   bgpn.bgpn_minor));
+            break;
         case BGP_NOTIFY_MAJOR_CAP:
             ND_PRINT((ndo, " subcode %s (%u)",
                   tok2str(bgp_notify_minor_cap_values, "Unknown",
                              bgpn.bgpn_minor),
                   bgpn.bgpn_minor));
+            break;
         case BGP_NOTIFY_MAJOR_CEASE:
             ND_PRINT((ndo, ", subcode %s (%u)",
                   tok2str(bgp_notify_minor_cease_values, "Unknown",