We're not copying the string to buf, so print the string, not buf.

Get rid of the now-unused buf array while we're at it.

diff --git a/print-rpki-rtr.c b/print-rpki-rtr.c
index fab4ec4fac2c76924a4acb353dd012d76953f863..34e2057b1aae8de4dfba2d6d5c4a4a8069c6fe8c 100644 (file)
--- a/print-rpki-rtr.c
+++ b/print-rpki-rtr.c
@@ -251,7 +251,6 @@ rpki_rtr_pdu_print (netdissect_options *ndo, const u_char *tptr, u_int indent)
        {
            rpki_rtr_pdu_error_report *pdu;
            u_int encapsulated_pdu_length, text_length, tlen, error_code;
-           u_char buf[80];
 
            pdu = (rpki_rtr_pdu_error_report *)tptr;
            encapsulated_pdu_length = EXTRACT_32BITS(pdu->encapsulated_pdu_length);
@@ -291,7 +290,7 @@ rpki_rtr_pdu_print (netdissect_options *ndo, const u_char *tptr, u_int indent)
            ND_TCHECK2(*tptr, text_length);
            if (text_length && (text_length <= tlen )) {
                ND_PRINT((ndo, "%sError text: ", indent_string(indent+2)));
-               fn_printn(ndo, buf, text_length, ndo->ndo_snapend);
+               fn_printn(ndo, tptr, text_length, ndo->ndo_snapend);
            }
        }
        break;

diff --git a/tests/kday4.out b/tests/kday4.out
index 0eb6080ac82b6e29be26e2692bf0ef732225dbac..95b29cc3e0dd3d7a47c8f608d5c27b638191ff27 100644 (file)
--- a/tests/kday4.out
+++ b/tests/kday4.out
@@ -54,7 +54,7 @@ IP (tos 0x0, ttl 64, id 36752, offset 0, flags [DF], proto TCP (6), length 399,
          0x0030:  afc4 39a4 0db9 7aa5 6873 33e8
        RPKI-RTRv65, Error Report PDU (10), length: 66
          Error code: Unknown (66), Encapsulated PDU length: 100
-         Error text: 
+         Error text: ^@^@^@M-^?M-^?^_^[pM-xWM-nhMM-}M_M-YM-=M-G^I0M-,M-^AvM-3mM-L^Q:M-?^RM-^QM-q^FNM-^aM-tbM-^WM-/M-D9M-$^MM-9zM-%hs3M-hA^J^@B^@^@^@B^@^@^@%M-Dz^HM-i^RM-^DM-5M-^\M->0H^H^@E^P^@4M-}&@^@>^F
        RPKI-RTRv115, Error Report PDU (10), length: 66|trunc
        [|RPKI-RTR]
 EXIT CODE 00000100

diff --git a/tests/kday5.out b/tests/kday5.out
index 50c48b2ecead79ef72d504cb6f5dbcbbc9df2327..7aeae727abad6fdb276b45202df3cd8742d75147 100644 (file)
--- a/tests/kday5.out
+++ b/tests/kday5.out
@@ -30,6 +30,6 @@ IP (tos 0x0, ttl 64, id 36752, offset 0, flags [DF], proto TCP (6), length 399,
          0x0030:  afc4 39a4 0db9 7aa5 6873 33e8
        RPKI-RTRv65, Error Report PDU (10), length: 66
          Error code: Unknown (66), Encapsulated PDU length: 80
-         Error text: 
+         Error text: M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-CM-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9M-9^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^V^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J^J
        [|RPKI-RTR]
 EXIT CODE 00000100