]> The Tcpdump Group git mirrors - tcpdump/commitdiff
FR: Add parentheses when extracting the flags
authorFrancois-Xavier Le Bail <[email protected]>
Sat, 23 Dec 2017 11:09:08 +0000 (12:09 +0100)
committerFrancois-Xavier Le Bail <[email protected]>
Sat, 23 Dec 2017 11:20:37 +0000 (12:20 +0100)
Should fix Coverity CID 1426919.

print-fr.c

index 5e0fb65a6ca2dc0462db2ab89d7a05b2ca8a6c69..45ffb24a6afac8743df1bcfda400eb500ebd2f00 100644 (file)
@@ -112,8 +112,8 @@ static int parse_q922_header(netdissect_options *ndo,
        *addr_len = 2;
        *dlci = ((EXTRACT_U_1(p) & 0xFC) << 2) | ((EXTRACT_U_1(p + 1) & 0xF0) >> 4);
 
-       *flags = (EXTRACT_U_1(p) & 0x02 << 24) |        /* CR flag */
-                (EXTRACT_U_1(p + 1) & 0x0e) << 16;     /* FECN,BECN,DE flags */
+       *flags = ((EXTRACT_U_1(p) & 0x02) << 24) |      /* CR flag */
+                ((EXTRACT_U_1(p + 1) & 0x0e) << 16);   /* FECN,BECN,DE flags */
 
        if (EXTRACT_U_1(p + 1) & FR_EA_BIT)
                return 1;       /* 2-byte Q.922 address */