The item_len argument to ikev1_id_print() *is* used.

So don't mark it as unused; that *might* be what's causing Coverity to
think that sizeof(struct ikev1_pl_id) is always < item_len and thus that
the "data" variable can never be null.

diff --git a/print-isakmp.c b/print-isakmp.c
index 5ee23f8639630aefef7b7f6c6c66a706629d960f..9fe567d128bd2d4f29658902f8a9ab87c1aaf2a9 100644 (file)
--- a/print-isakmp.c
+++ b/print-isakmp.c
@@ -1306,7 +1306,7 @@ trunc:
 
 static const u_char *
 ikev1_id_print(netdissect_options *ndo, u_char tpay _U_,
-              const struct isakmp_gen *ext, u_int item_len _U_,
+              const struct isakmp_gen *ext, u_int item_len,
               const u_char *ep _U_, u_int32_t phase, u_int32_t doi _U_,
               u_int32_t proto _U_, int depth _U_)
 {