That array only needs 16 elements.

No need for a 17th null terminator.

This might, or might not, give Coverity a clue that

	u_char *p;

	hex[*p >> 4]
	hex[*p & 0xf]

are both safe, no matter how "tainted" p is, because if you shift an
8-bit unsigned value right 4 bits, the result is between 0 and 15.  (See
CID 1206732.)

diff --git a/addrtoname.c b/addrtoname.c
index 11ac08e33d14cfaaa26d516fb6d07423223c6518..df7c2cee9461f8e1c081b87a3af34bd619af9985 100644 (file)
--- a/addrtoname.c
+++ b/addrtoname.c
@@ -331,7 +331,7 @@ getname6(netdissect_options *ndo, const u_char *ap)
        return (p->name);
 }
 
-static const char hex[] = "0123456789abcdef";
+static const char hex[16] = "0123456789abcdef";
 
 
 /* Find the hash node that corresponds the ether address 'ep' */