]> The Tcpdump Group git mirrors - tcpdump/commitdiff
OLSR: fix "Unchecked return value" found by Coverity
authorFrancois-Xavier Le Bail <[email protected]>
Mon, 8 Dec 2014 21:18:16 +0000 (22:18 +0100)
committerFrancois-Xavier Le Bail <[email protected]>
Mon, 8 Dec 2014 21:18:16 +0000 (22:18 +0100)
The bounds check is already done before by ND_TCHECK2(*msg_data, addr_size +
name_entry_len + name_entry_padding).
So we are deliberately ignoring the return values of fn_printn with last
argument NULL (no bounds check).

print-olsr.c

index 6d2d65f28c6768eee98534b5cb763427af48afb4..b90eea1aa3047a3569a0affdb99b80d802e07439 100644 (file)
@@ -609,7 +609,7 @@ olsr_print(netdissect_options *ndo,
 #endif
                     ND_PRINT((ndo, ", address %s, name \"",
                             ipaddr_string(ndo, msg_data)));
-                fn_printn(ndo, msg_data + addr_size, name_entry_len, NULL);
+                (void)fn_printn(ndo, msg_data + addr_size, name_entry_len, NULL);
                 ND_PRINT((ndo, "\""));
 
                 msg_data += addr_size + name_entry_len + name_entry_padding;